OSDN Git Service

[media] media: venus: vdec: fix compile error in vdec_close
authorStanimir Varbanov <stanimir.varbanov@linaro.org>
Thu, 15 Jun 2017 16:31:56 +0000 (13:31 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 20 Jun 2017 11:53:41 +0000 (08:53 -0300)
This fixes the following compile error ocured when building
with gcc7:

drivers/media/platform/qcom/venus/vdec.c:1022
vdec_close() error: dereferencing freed memory 'inst'

by moving kfree as a last call.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/qcom/venus/vdec.c

index 96e7e7e..594315b 100644 (file)
@@ -1017,9 +1017,10 @@ static int vdec_close(struct file *file)
        mutex_destroy(&inst->lock);
        v4l2_fh_del(&inst->fh);
        v4l2_fh_exit(&inst->fh);
-       kfree(inst);
 
        pm_runtime_put_sync(inst->core->dev_dec);
+
+       kfree(inst);
        return 0;
 }