Remove AtStart_Cache() call in CommandCounterIncrement().

This call was present in the aboriginal code from Berkeley, and has
never been touched; it may very well be that it was there to mask
effects of bugs in other places and it may no longer be necessary.
The removal has been foreseen in a code comment since 2007; this seems
to be a good time to test this hypothesis.

diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
index b02db9e..d2e2e11 100644 (file)
--- a/src/backend/access/transam/xact.c
+++ b/src/backend/access/transam/xact.c
@@ -729,17 +729,6 @@ CommandCounterIncrement(void)
                 */
                AtCCI_LocalCache();
        }
-
-       /*
-        * Make any other backends' catalog changes visible to me.
-        *
-        * XXX this is probably in the wrong place: CommandCounterIncrement should
-        * be purely a local operation, most likely.  However fooling with this
-        * will affect asynchronous cross-backend interactions, which doesn't seem
-        * like a wise thing to do in late beta, so save improving this for
-        * another day - tgl 2007-11-30
-        */
-       AtStart_Cache();
 }
 
 /*