OSDN Git Service

irqchip/renesas-irqc: Use proper irq_chip name and parent
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 7 Jun 2019 09:58:56 +0000 (11:58 +0200)
committerMarc Zyngier <marc.zyngier@arm.com>
Tue, 11 Jun 2019 11:22:42 +0000 (12:22 +0100)
The irq_chip .name field should contain the device's class (not
instance) name, while .parent_device should point to the device itself.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-renesas-irqc.c

index cde9f9c..11abc09 100644 (file)
@@ -176,7 +176,7 @@ static int irqc_probe(struct platform_device *pdev)
        }
 
        ret = irq_alloc_domain_generic_chips(p->irq_domain, p->number_of_irqs,
-                                            1, name, handle_level_irq,
+                                            1, "irqc", handle_level_irq,
                                             0, 0, IRQ_GC_INIT_NESTED_LOCK);
        if (ret) {
                dev_err(dev, "cannot allocate generic chip\n");
@@ -187,6 +187,7 @@ static int irqc_probe(struct platform_device *pdev)
        p->gc->reg_base = p->cpu_int_base;
        p->gc->chip_types[0].regs.enable = IRQC_EN_SET;
        p->gc->chip_types[0].regs.disable = IRQC_EN_STS;
+       p->gc->chip_types[0].chip.parent_device = dev;
        p->gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg;
        p->gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg;
        p->gc->chip_types[0].chip.irq_set_type  = irqc_irq_set_type;