OSDN Git Service

phylink: ensure the PHY interface mode is appropriately set
authorRussell King <rmk+kernel@armlinux.org.uk>
Wed, 20 Dec 2017 23:21:28 +0000 (23:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Dec 2017 02:47:19 +0000 (21:47 -0500)
When setting the ethtool settings, ensure that the validated PHY
interface mode is propagated to the current link settings, so that
2500BaseX can be selected.

Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c

index 5dc9668..8d06a08 100644 (file)
@@ -951,6 +951,7 @@ int phylink_ethtool_ksettings_set(struct phylink *pl,
        mutex_lock(&pl->state_mutex);
        /* Configure the MAC to match the new settings */
        linkmode_copy(pl->link_config.advertising, our_kset.link_modes.advertising);
+       pl->link_config.interface = config.interface;
        pl->link_config.speed = our_kset.base.speed;
        pl->link_config.duplex = our_kset.base.duplex;
        pl->link_config.an_enabled = our_kset.base.autoneg != AUTONEG_DISABLE;