OSDN Git Service

ASoC: qcom: q6dsp-dai: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 18 Feb 2021 22:29:09 +0000 (16:29 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:01:51 +0000 (13:01 +0000)
cppcheck warning:

sound/soc/qcom/qdsp6/q6afe-dai.c:264:35: style: Clarify calculation
precedence for '&' and '?'. [clarifyCalculation]
  tdm->slot_mask = (dai->id & 0x1 ? tx_mask : rx_mask) & cap_mask;
                                  ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210218222916.89809-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/qdsp6/q6afe-dai.c

index 4e1f101..3b52abe 100644 (file)
@@ -261,7 +261,7 @@ static int q6tdm_set_tdm_slot(struct snd_soc_dai *dai,
                tdm->nslots_per_frame = slots;
                tdm->slot_width = slot_width;
                /* TDM RX dais ids are even and tx are odd */
-               tdm->slot_mask = (dai->id & 0x1 ? tx_mask : rx_mask) & cap_mask;
+               tdm->slot_mask = ((dai->id & 0x1) ? tx_mask : rx_mask) & cap_mask;
                break;
        default:
                dev_err(dai->dev, "%s: invalid dai id 0x%x\n",