OSDN Git Service

powerpc/xive: Add missing null check after calling kmalloc
authorAmmar Faizi <ammarfaizi2@gmail.com>
Sun, 26 Dec 2021 13:54:02 +0000 (20:54 +0700)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 4 Jan 2022 05:03:05 +0000 (16:03 +1100)
Commit 930914b7d528fc ("powerpc/xive: Add a debugfs file to dump
internal XIVE state") forgot to add a null check.

Add it.

Fixes: 930914b7d528fc6b0249bffc00564100bcf6ef75 ("powerpc/xive: Add a debugfs file to dump internal XIVE state")
Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211226135314.251221-1-ammar.faizi@intel.com
arch/powerpc/sysdev/xive/spapr.c

index dfc4634..928f950 100644 (file)
@@ -653,6 +653,9 @@ static int xive_spapr_debug_show(struct seq_file *m, void *private)
        struct xive_irq_bitmap *xibm;
        char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
 
+       if (!buf)
+               return -ENOMEM;
+
        list_for_each_entry(xibm, &xive_irq_bitmaps, list) {
                memset(buf, 0, PAGE_SIZE);
                bitmap_print_to_pagebuf(true, buf, xibm->bitmap, xibm->count);