OSDN Git Service

fb: amifb: fix build warnings when not builtin
authorRandy Dunlap <rdunlap@infradead.org>
Tue, 31 Jul 2018 11:06:58 +0000 (13:06 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tue, 31 Jul 2018 11:06:58 +0000 (13:06 +0200)
Fix build warning when built as a loadable module.
amifb_setup() and amifb_setup_mcap() are only needed when the driver
is builtin.
This matches how the functions are called (using #ifndef MODULE).

../drivers/video/fbdev/amifb.c:2344:19: warning: 'amifb_setup' defined but not used [-Wunused-function]
 static int __init amifb_setup(char *options)

../drivers/video/fbdev/amifb.c:2307:20: warning: 'amifb_setup_mcap' defined but not used [-Wunused-function]
 static void __init amifb_setup_mcap(char *spec)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/amifb.c

index cc11c60..0777aff 100644 (file)
@@ -2303,7 +2303,7 @@ static void ami_build_copper(struct fb_info *info)
        ami_rebuild_copper(info->par);
 }
 
-
+#ifndef MODULE
 static void __init amifb_setup_mcap(char *spec)
 {
        char *p;
@@ -2368,7 +2368,7 @@ static int __init amifb_setup(char *options)
 
        return 0;
 }
-
+#endif
 
 static int amifb_check_var(struct fb_var_screeninfo *var,
                           struct fb_info *info)