OSDN Git Service

drivers: tty: serial: IMX_EARLYCON: fix Kconfig dependency on SERIAL_CORE
authorJulian Braha <julianbraha@gmail.com>
Thu, 25 Feb 2021 04:42:48 +0000 (23:42 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Mar 2021 08:34:09 +0000 (09:34 +0100)
When SERIAL_IMX_EARLYCON is enabled, and SERIAL_CORE is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for SERIAL_EARLYCON
  Depends on [n]: TTY [=y] && HAS_IOMEM [=y] && SERIAL_CORE [=n]
  Selected by [y]:
  - SERIAL_IMX_EARLYCON [=y] && TTY [=y] && HAS_IOMEM [=y] && (ARCH_MXC [=y] || COMPILE_TEST [=n]) && OF [=y]

This is because SERIAL_IMX_EARLYCON selects SERIAL_EARLYCON,
without selecting SERIAL_CORE, despite that config option depending
on SERIAL_CORE.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
Link: https://lore.kernel.org/r/20210225044248.4745-1-julianbraha@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/Kconfig

index 0c4cd4a..fb9731d 100644 (file)
@@ -498,6 +498,7 @@ config SERIAL_IMX_EARLYCON
        bool "Earlycon on IMX serial port"
        depends on ARCH_MXC || COMPILE_TEST
        depends on OF
+       select SERIAL_CORE
        select SERIAL_EARLYCON
        select SERIAL_CORE_CONSOLE
        default y if SERIAL_IMX_CONSOLE