OSDN Git Service

net/mlx5: Pair mutex_destory with mutex_init for rate limit table
authorParav Pandit <parav@nvidia.com>
Fri, 19 Feb 2021 07:36:54 +0000 (09:36 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Fri, 2 Apr 2021 23:13:06 +0000 (16:13 -0700)
Add missing mutex_destroy() to pair with mutex_init().

This should be done only when table is initialized, hence perform
mutex_init() only when table is initialized.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/rl.c

index 0526e37..7161220 100644 (file)
@@ -367,12 +367,13 @@ int mlx5_init_rl_table(struct mlx5_core_dev *dev)
 {
        struct mlx5_rl_table *table = &dev->priv.rl_table;
 
-       mutex_init(&table->rl_lock);
        if (!MLX5_CAP_GEN(dev, qos) || !MLX5_CAP_QOS(dev, packet_pacing)) {
                table->max_size = 0;
                return 0;
        }
 
+       mutex_init(&table->rl_lock);
+
        /* First entry is reserved for unlimited rate */
        table->max_size = MLX5_CAP_QOS(dev, packet_pacing_rate_table_size) - 1;
        table->max_rate = MLX5_CAP_QOS(dev, packet_pacing_max_rate);
@@ -394,4 +395,5 @@ void mlx5_cleanup_rl_table(struct mlx5_core_dev *dev)
                return;
 
        mlx5_rl_table_free(dev, table);
+       mutex_destroy(&table->rl_lock);
 }