OSDN Git Service

drm/exynos: fimc: signedness bug in fimc_setup_clocks()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 18 May 2018 08:04:45 +0000 (01:04 -0700)
committerInki Dae <inki.dae@samsung.com>
Fri, 25 May 2018 05:47:40 +0000 (14:47 +0900)
"id" needs to be signed for the error handling to work.

Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_fimc.c

index 4dfbfc7..5ce8402 100644 (file)
@@ -1200,7 +1200,7 @@ e_clk_free:
 
 int exynos_drm_check_fimc_device(struct device *dev)
 {
-       unsigned int id = of_alias_get_id(dev->of_node, "fimc");
+       int id = of_alias_get_id(dev->of_node, "fimc");
 
        if (id >= 0 && (BIT(id) & fimc_mask))
                return 0;