OSDN Git Service

net: fec: initialize clock with 0 rather than current kernel time
authorSergey Organov <sorganov@gmail.com>
Wed, 15 Jul 2020 15:42:58 +0000 (18:42 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 16 Jul 2020 18:31:54 +0000 (11:31 -0700)
Initializing with 0 makes it much easier to identify time stamps from
otherwise uninitialized clock.

Initialization of PTP clock with current kernel time makes little sense as
PTP time scale differs from UTC time scale that kernel time represents.
It only leads to confusion when no actual PTP initialization happens, as
these time scales differ in a small integer number of seconds (37 at the
time of writing.)

Signed-off-by: Sergey Organov <sorganov@gmail.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_ptp.c

index fda306b..4bec7e6 100644 (file)
@@ -264,7 +264,7 @@ void fec_ptp_start_cyclecounter(struct net_device *ndev)
        fep->cc.mult = FEC_CC_MULT;
 
        /* reset the ns time counter */
-       timecounter_init(&fep->tc, &fep->cc, ktime_to_ns(ktime_get_real()));
+       timecounter_init(&fep->tc, &fep->cc, 0);
 
        spin_unlock_irqrestore(&fep->tmreg_lock, flags);
 }