OSDN Git Service

pinctrl: freescale: off by one in imx1_pinconf_group_dbg_show()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 13 Jul 2018 14:55:15 +0000 (17:55 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 1 Aug 2018 21:01:07 +0000 (23:01 +0200)
The info->groups[] array is allocated in imx1_pinctrl_parse_dt().  It
has info->ngroups elements.  Thus the > here should be >= to prevent
reading one element beyond the end of the array.

Cc: stable@vger.kernel.org
Fixes: 30612cd90005 ("pinctrl: imx1 core driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Uwe Kleine-König <u.kleine-könig@pengutronix.de>
Acked-by: Dong Aisheng <Aisheng.dong@nxp.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/freescale/pinctrl-imx1-core.c

index c3bdd90..deb7870 100644 (file)
@@ -429,7 +429,7 @@ static void imx1_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
        const char *name;
        int i, ret;
 
-       if (group > info->ngroups)
+       if (group >= info->ngroups)
                return;
 
        seq_puts(s, "\n");