OSDN Git Service

[PATCH] jfs: incorrect use of "&&" instead of "&"
authorWilly Tarreau <w@1wt.eu>
Sat, 25 Nov 2006 20:57:26 +0000 (21:57 +0100)
committerWilly Tarreau <w@1wt.eu>
Sat, 25 Nov 2006 21:37:39 +0000 (22:37 +0100)
in jfs_txnmgr, the use of "tblk->flag && COMMIT_DELETE" in a
if() condition is obviously wrong. This bug has already been
fixed in 2.6.

Signed-off-by: Willy Tarreau <w@1wt.eu>
Acked-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
fs/jfs/jfs_txnmgr.c

index 62e6493..4e6a280 100644 (file)
@@ -1175,7 +1175,7 @@ int txCommit(tid_t tid,           /* transaction identifier */
                jfs_ip = JFS_IP(ip);
 
                if (test_and_clear_cflag(COMMIT_Syncdata, ip) &&
-                   ((tblk->flag && COMMIT_DELETE) == 0))
+                   ((tblk->flag & COMMIT_DELETE) == 0))
                        fsync_inode_data_buffers(ip);
 
                /*