OSDN Git Service

drm/i915/display: Do not check for the ddb allocations of turned off pipes
authorJosé Roberto de Souza <jose.souza@intel.com>
Thu, 5 Dec 2019 21:03:48 +0000 (13:03 -0800)
committerJosé Roberto de Souza <jose.souza@intel.com>
Fri, 6 Dec 2019 23:19:36 +0000 (15:19 -0800)
It should not care about DDB allocations of pipes going through
a fullmodeset, as at this point those pipes are disabled.
The comment in the code also points to that but that was not what
was being executed.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191205210350.96795-1-jose.souza@intel.com
drivers/gpu/drm/i915/display/intel_display.c

index 63f9566..cd8a171 100644 (file)
@@ -14603,7 +14603,7 @@ static void skl_commit_modeset_enables(struct intel_atomic_state *state)
 
        for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i)
                /* ignore allocations for crtc's that have been turned off. */
-               if (new_crtc_state->hw.active)
+               if (!needs_modeset(new_crtc_state) && new_crtc_state->hw.active)
                        entries[i] = old_crtc_state->wm.skl.ddb;
 
        /* If 2nd DBuf slice required, enable it here */