OSDN Git Service

media: atomisp: Remove atomisp_ospm_dphy_down() call from probe error path
authorHans de Goede <hdegoede@redhat.com>
Mon, 14 Nov 2022 16:00:51 +0000 (16:00 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 25 Nov 2022 08:24:31 +0000 (08:24 +0000)
The only thing which atomisp_ospm_dphy_down() does is disable the CSI
pins, but if we failed to probe the ISP then these will never have
been enabled (because the ISP never started streaming).

So the atomisp_ospm_dphy_down() call in the probe error path is
unnecessary, remove it.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_v4l2.c

index f46046d..9cb1363 100644 (file)
@@ -1673,8 +1673,6 @@ load_fw_fail:
 
        atomisp_msi_irq_uninit(isp);
 
-       atomisp_ospm_dphy_down(isp);
-
        /* Address later when we worry about the ...field chips */
        if (IS_ENABLED(CONFIG_PM) && atomisp_mrfld_power(isp, false))
                dev_err(&pdev->dev, "Failed to switch off ISP\n");