OSDN Git Service

iio: dummy_evgen: modify the return value check for irq_sim_init()
authorBartosz Golaszewski <brgl@bgdev.pl>
Mon, 27 Nov 2017 10:54:49 +0000 (11:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Jan 2018 15:03:41 +0000 (16:03 +0100)
As discussed with Marc Zyngier: irq_sim_init() and its devres variant
should return the base of the allocated interrupt range on success
rather than 0. This will be modified later - first, change the way
users handle the return value of these routines.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/dummy/iio_dummy_evgen.c

index fe88845..efd0005 100644 (file)
@@ -56,7 +56,7 @@ static int iio_dummy_evgen_create(void)
                return -ENOMEM;
 
        ret = irq_sim_init(&iio_evgen->irq_sim, IIO_EVENTGEN_NO);
-       if (ret) {
+       if (ret < 0) {
                kfree(iio_evgen);
                return ret;
        }