OSDN Git Service

HID: picoLCD: constify fb ops
authorJani Nikula <jani.nikula@intel.com>
Tue, 3 Dec 2019 16:38:51 +0000 (18:38 +0200)
committerJani Nikula <jani.nikula@intel.com>
Mon, 9 Dec 2019 13:49:16 +0000 (15:49 +0200)
Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.

v2: fix typo (Christophe de Dinechin)

Cc: Bruno Prémont <bonbons@linux-vserver.org>
Cc: linux-input@vger.kernel.org
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/f415010cd52cce7d8a1250d4eca582ec64e67956.1575390741.git.jani.nikula@intel.com
drivers/hid/hid-picolcd_fb.c

index e162a66..a549c42 100644 (file)
@@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info)
        return 0;
 }
 
-/* Note this can't be const because of struct fb_info definition */
-static struct fb_ops picolcdfb_ops = {
+static const struct fb_ops picolcdfb_ops = {
        .owner        = THIS_MODULE,
        .fb_destroy   = picolcd_fb_destroy,
        .fb_read      = fb_sys_read,