OSDN Git Service

drm/amd/powerplay: Fix maybe-uninitialized in get_ppfeature_status
authorBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Wed, 15 May 2019 20:17:05 +0000 (16:17 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 24 May 2019 17:21:00 +0000 (12:21 -0500)
This fixes the warning below

error: ‘feature_mask’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  *features_enabled = ((((uint64_t)feature_mask[0] << SMU_FEATURES_LOW_SHIFT) & SMU_FEATURES_LOW_MASK) |
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
    (((uint64_t)feature_mask[1] << SMU_FEATURES_HIGH_SHIFT) & SMU_FEATURES_HIGH_MASK));
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/vega20_ppt.c

index b39f3d4..4aa8f5a 100644 (file)
@@ -2377,7 +2377,7 @@ static int vega20_odn_edit_dpm_table(struct smu_context *smu,
 static int vega20_get_enabled_smc_features(struct smu_context *smu,
                uint64_t *features_enabled)
 {
-       uint32_t feature_mask[2];
+       uint32_t feature_mask[2] = {0, 0};
        int ret = 0;
 
        ret = smu_feature_get_enabled_mask(smu, feature_mask, 2);