OSDN Git Service

cxl/region: Validate region mode vs decoder mode
authorDan Williams <dan.j.williams@intel.com>
Fri, 10 Feb 2023 09:05:51 +0000 (01:05 -0800)
committerDan Williams <dan.j.williams@intel.com>
Sat, 11 Feb 2023 01:32:05 +0000 (17:32 -0800)
In preparation for a new region mode, do not, for example, allow
'ram' decoders to be assigned to 'pmem' regions and vice versa.

Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Reviewed-by: Gregory Price <gregory.price@memverge.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Tested-by: Fan Ni <fan.ni@samsung.com>
Link: https://lore.kernel.org/r/167601995111.1924368.7459128614177994602.stgit@dwillia2-xfh.jf.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/core/region.c

index 0fc8047..2858351 100644 (file)
@@ -1221,6 +1221,12 @@ static int cxl_region_attach(struct cxl_region *cxlr,
        struct cxl_dport *dport;
        int i, rc = -ENXIO;
 
+       if (cxled->mode != cxlr->mode) {
+               dev_dbg(&cxlr->dev, "%s region mode: %d mismatch: %d\n",
+                       dev_name(&cxled->cxld.dev), cxlr->mode, cxled->mode);
+               return -EINVAL;
+       }
+
        if (cxled->mode == CXL_DECODER_DEAD) {
                dev_dbg(&cxlr->dev, "%s dead\n", dev_name(&cxled->cxld.dev));
                return -ENODEV;