OSDN Git Service

Input: edt-ft5x06 - use get_unaligned_be16()
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Sun, 23 Jun 2019 06:11:51 +0000 (23:11 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sun, 30 Jun 2019 07:18:12 +0000 (00:18 -0700)
Instead of doing conversion by hand, let's use the proper accessors.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Tested-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/edt-ft5x06.c

index c639ebc..ec77022 100644 (file)
@@ -27,6 +27,7 @@
 #include <linux/gpio/consumer.h>
 #include <linux/input/mt.h>
 #include <linux/input/touchscreen.h>
+#include <asm/unaligned.h>
 
 #define WORK_REGISTER_THRESHOLD                0x00
 #define WORK_REGISTER_REPORT_RATE      0x08
@@ -239,8 +240,8 @@ static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev_id)
                if (tsdata->version == EDT_M06 && type == TOUCH_EVENT_DOWN)
                        continue;
 
-               x = ((buf[0] << 8) | buf[1]) & 0x0fff;
-               y = ((buf[2] << 8) | buf[3]) & 0x0fff;
+               x = get_unaligned_be16(buf) & 0x0fff;
+               y = get_unaligned_be16(buf + 2) & 0x0fff;
                /* The FT5x26 send the y coordinate first */
                if (tsdata->version == EV_FT)
                        swap(x, y);