OSDN Git Service

netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()
authorPaul Moore <paul@paul-moore.com>
Fri, 13 Nov 2020 21:30:40 +0000 (16:30 -0500)
committerJakub Kicinski <kuba@kernel.org>
Sat, 14 Nov 2020 20:07:57 +0000 (12:07 -0800)
Static checking revealed that a previous fix to
netlbl_unlabel_staticlist() leaves a stack variable uninitialized,
this patches fixes that.

Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Reviewed-by: James Morris <jamorris@linux.microsoft.com>
Link: https://lore.kernel.org/r/160530304068.15651.18355773009751195447.stgit@sifl
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/netlabel/netlabel_unlabeled.c

index fc55c91..ccb4916 100644 (file)
@@ -1167,7 +1167,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb,
        u32 skip_bkt = cb->args[0];
        u32 skip_chain = cb->args[1];
        u32 skip_addr4 = cb->args[2];
-       u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0;
+       u32 iter_bkt, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0;
        struct netlbl_unlhsh_iface *iface;
        struct list_head *iter_list;
        struct netlbl_af4list *addr4;