OSDN Git Service

net: packetengines: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
authorYang Wei <yang.wei9@zte.com.cn>
Thu, 14 Feb 2019 14:52:28 +0000 (22:52 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Feb 2019 17:43:15 +0000 (12:43 -0500)
dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/packetengines/hamachi.c
drivers/net/ethernet/packetengines/yellowfin.c

index c9529c2..eee883a 100644 (file)
@@ -1337,7 +1337,7 @@ static irqreturn_t hamachi_interrupt(int irq, void *dev_instance)
                                                        leXX_to_cpu(hmp->tx_ring[entry].addr),
                                                        skb->len,
                                                        PCI_DMA_TODEVICE);
-                                               dev_kfree_skb_irq(skb);
+                                               dev_consume_skb_irq(skb);
                                                hmp->tx_skbuff[entry] = NULL;
                                        }
                                        hmp->tx_ring[entry].status_n_length = 0;
index 54224d1..6f8d658 100644 (file)
@@ -925,7 +925,7 @@ static irqreturn_t yellowfin_interrupt(int irq, void *dev_instance)
                        /* Free the original skb. */
                        pci_unmap_single(yp->pci_dev, le32_to_cpu(yp->tx_ring[entry].addr),
                                skb->len, PCI_DMA_TODEVICE);
-                       dev_kfree_skb_irq(skb);
+                       dev_consume_skb_irq(skb);
                        yp->tx_skbuff[entry] = NULL;
                }
                if (yp->tx_full &&
@@ -983,7 +983,7 @@ static irqreturn_t yellowfin_interrupt(int irq, void *dev_instance)
                                pci_unmap_single(yp->pci_dev,
                                        yp->tx_ring[entry<<1].addr, skb->len,
                                        PCI_DMA_TODEVICE);
-                               dev_kfree_skb_irq(skb);
+                               dev_consume_skb_irq(skb);
                                yp->tx_skbuff[entry] = 0;
                                /* Mark status as empty. */
                                yp->tx_status[entry].tx_errs = 0;