OSDN Git Service

xfrm: fix bogus WARN_ON with ipv6
authorFlorian Westphal <fw@strlen.de>
Wed, 12 Jun 2019 08:30:58 +0000 (10:30 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Wed, 12 Jun 2019 09:01:56 +0000 (11:01 +0200)
net/xfrm/xfrm_input.c:378:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
skb->protocol = htons(ETH_P_IPV6);

... the fallthrough then causes a bogus WARN_ON().

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 4c203b0454b ("xfrm: remove eth_proto value from xfrm_state_afinfo")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_input.c

index 8a00cc9..6088bc2 100644 (file)
@@ -376,6 +376,7 @@ static int xfrm_prepare_input(struct xfrm_state *x, struct sk_buff *skb)
                break;
        case AF_INET6:
                skb->protocol = htons(ETH_P_IPV6);
+               break;
        default:
                WARN_ON_ONCE(1);
                break;