Cppcheck: Common realloc mistake: 'ptr' nulled but not freed upon failure

diff --git a/Src/Common/unicoder.cpp b/Src/Common/unicoder.cpp
index 5f2147f..eb56494 100644 (file)
--- a/Src/Common/unicoder.cpp
+++ b/Src/Common/unicoder.cpp
@@ -818,7 +818,10 @@ void buffer::resize(size_t newSize)
        if (capacity < newSize)
        {
                capacity = newSize;
-               ptr = (unsigned char *)realloc(ptr, capacity);
+               unsigned char *tmp = static_cast<unsigned char *>(realloc(ptr, capacity));
+               if (!tmp)
+                       throw std::bad_alloc();
+               ptr = tmp;
        }
 }