OSDN Git Service

LSM: SafeSetID: Fix code specification by scripts/checkpatch.pl
authorYanwei Gao <gaoyanwei.tx@gmail.com>
Wed, 10 Mar 2021 06:52:12 +0000 (06:52 +0000)
committerMicah Morton <mortonm@chromium.org>
Mon, 26 Apr 2021 23:36:50 +0000 (16:36 -0700)
First, the code is found to be irregular through checkpatch.pl.
Then I found break is really useless here.

Signed-off-by: Yanwei Gao <gaoyanwei.tx@gmail.com>
Signed-off-by: Micah Morton <mortonm@chromium.org>
security/safesetid/lsm.c

index 8a176b6..1079c6d 100644 (file)
@@ -125,7 +125,6 @@ static int safesetid_security_capable(const struct cred *cred,
                pr_warn("Operation requires CAP_SETUID, which is not available to UID %u for operations besides approved set*uid transitions\n",
                        __kuid_val(cred->uid));
                return -EPERM;
-               break;
        case CAP_SETGID:
                /*
                * If no policy applies to this task, allow the use of CAP_SETGID for
@@ -140,11 +139,9 @@ static int safesetid_security_capable(const struct cred *cred,
                pr_warn("Operation requires CAP_SETGID, which is not available to GID %u for operations besides approved set*gid transitions\n",
                        __kuid_val(cred->uid));
                return -EPERM;
-               break;
        default:
                /* Error, the only capabilities were checking for is CAP_SETUID/GID */
                return 0;
-               break;
        }
        return 0;
 }