optimize SOCK_CLOEXEC fallback for socket function

the fcntl function is heavy, so make the syscall directly instead.
also, avoid the code size and runtime overhead of querying the old
flags, since it's reasonable to assume nothing will be set on a
newly-created socket. this code is only used on old kernels which lack
proper atomic close-on-exec support, so future changes that might
invalidate such an assumption do not need to be considered.

diff --git a/src/network/socket.c b/src/network/socket.c
index 51be30e..a2e92d9 100644 (file)
--- a/src/network/socket.c
+++ b/src/network/socket.c
@@ -13,9 +13,9 @@ int socket(int domain, int type, int protocol)
                        protocol, 0, 0, 0);
                if (s < 0) return s;
                if (type & SOCK_CLOEXEC)
-                       fcntl(s, F_SETFD, FD_CLOEXEC);
+                       __syscall(SYS_fcntl, s, F_SETFD, FD_CLOEXEC);
                if (type & SOCK_NONBLOCK)
-                       fcntl(s, F_SETFL, fcntl(s, F_GETFL) | O_NONBLOCK);
+                       __syscall(SYS_fcntl, s, F_SETFL, O_NONBLOCK);
        }
        return s;
 }