OSDN Git Service

flow_dissector: remove unused FLOW_DISSECTOR_F_STOP_AT_L3 flag
authorStanislav Fomichev <sdf@google.com>
Fri, 31 May 2019 21:05:06 +0000 (14:05 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Jun 2019 21:56:35 +0000 (14:56 -0700)
This flag is not used by any caller, remove it.

Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/flow_dissector.h
net/core/flow_dissector.c

index 7c5a8d9..797e19c 100644 (file)
@@ -229,9 +229,8 @@ enum flow_dissector_key_id {
 };
 
 #define FLOW_DISSECTOR_F_PARSE_1ST_FRAG                BIT(0)
-#define FLOW_DISSECTOR_F_STOP_AT_L3            BIT(1)
-#define FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL    BIT(2)
-#define FLOW_DISSECTOR_F_STOP_AT_ENCAP         BIT(3)
+#define FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL    BIT(1)
+#define FLOW_DISSECTOR_F_STOP_AT_ENCAP         BIT(2)
 
 struct flow_dissector_key {
        enum flow_dissector_key_id key_id;
index edd6229..c0559af 100644 (file)
@@ -757,7 +757,7 @@ bool bpf_flow_dissect(struct bpf_prog *prog, struct bpf_flow_dissector *ctx,
  * @nhoff: network header offset, if @data is NULL use skb_network_offset(skb)
  * @hlen: packet header length, if @data is NULL use skb_headlen(skb)
  * @flags: flags that control the dissection process, e.g.
- *         FLOW_DISSECTOR_F_STOP_AT_L3.
+ *         FLOW_DISSECTOR_F_STOP_AT_ENCAP.
  *
  * The function will try to retrieve individual keys into target specified
  * by flow_dissector from either the skbuff or a raw buffer specified by the
@@ -922,11 +922,6 @@ proto_again:
                __skb_flow_dissect_ipv4(skb, flow_dissector,
                                        target_container, data, iph);
 
-               if (flags & FLOW_DISSECTOR_F_STOP_AT_L3) {
-                       fdret = FLOW_DISSECT_RET_OUT_GOOD;
-                       break;
-               }
-
                break;
        }
        case htons(ETH_P_IPV6): {
@@ -975,9 +970,6 @@ proto_again:
                __skb_flow_dissect_ipv6(skb, flow_dissector,
                                        target_container, data, iph);
 
-               if (flags & FLOW_DISSECTOR_F_STOP_AT_L3)
-                       fdret = FLOW_DISSECT_RET_OUT_GOOD;
-
                break;
        }
        case htons(ETH_P_8021AD):