OSDN Git Service

mtd: terminate user-provided string
authorBrian Norris <computersforpeace@gmail.com>
Tue, 22 Jul 2014 02:08:13 +0000 (19:08 -0700)
committerBrian Norris <computersforpeace@gmail.com>
Tue, 19 Aug 2014 18:53:09 +0000 (11:53 -0700)
Noticed by Coverity as a potential security issue.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/mtdchar.c

index a0f54e8..5356395 100644 (file)
@@ -549,6 +549,9 @@ static int mtdchar_blkpg_ioctl(struct mtd_info *mtd,
                if (mtd_is_partition(mtd))
                        return -EINVAL;
 
+               /* Sanitize user input */
+               p.devname[BLKPG_DEVNAMELTH - 1] = '\0';
+
                return mtd_add_partition(mtd, p.devname, p.start, p.length);
 
        case BLKPG_DEL_PARTITION: