OSDN Git Service

drm/dp_mst: Convert drm_dp_mst_topology_mgr.is_waiting_for_dwn_reply to bitfield
authorLyude Paul <lyude@redhat.com>
Wed, 22 Jan 2020 19:48:46 +0000 (14:48 -0500)
committerLyude Paul <lyude@redhat.com>
Fri, 13 Mar 2020 18:52:35 +0000 (14:52 -0400)
Small nitpick that I noticed a second ago - we can save some space in
the struct by making this a bitfield and sticking it with the rest of
the bitfields. Also, some small cleanup to the kdocs for this member.

There should be no functional changes in this patch.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Wayne Lin <Wayne.Lin@amd.com>
Reviewed-by: Wayne Lin <Wayne.Lin@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200122194846.16025-1-lyude@redhat.com
include/drm/drm_dp_mst_helper.h

index 885ada3..9a1e8ba 100644 (file)
@@ -590,6 +590,11 @@ struct drm_dp_mst_topology_mgr {
        bool payload_id_table_cleared : 1;
 
        /**
+        * @is_waiting_for_dwn_reply: whether we're waiting for a down reply.
+        */
+       bool is_waiting_for_dwn_reply : 1;
+
+       /**
         * @mst_primary: Pointer to the primary/first branch device.
         */
        struct drm_dp_mst_branch *mst_primary;
@@ -619,11 +624,6 @@ struct drm_dp_mst_topology_mgr {
        struct mutex qlock;
 
        /**
-        * @is_waiting_for_dwn_reply: indicate whether is waiting for down reply
-        */
-       bool is_waiting_for_dwn_reply;
-
-       /**
         * @tx_msg_downq: List of pending down replies.
         */
        struct list_head tx_msg_downq;