OSDN Git Service

ipv4: remove redundant null pointer check before kfree_skb
authorzhong jiang <zhongjiang@huawei.com>
Thu, 20 Sep 2018 09:37:43 +0000 (17:37 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Sep 2018 16:04:37 +0000 (09:04 -0700)
kfree_skb has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree_skb.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_fragment.c

index da930b0..13f4d18 100644 (file)
@@ -260,8 +260,7 @@ out:
        spin_unlock(&qp->q.lock);
 out_rcu_unlock:
        rcu_read_unlock();
-       if (head)
-               kfree_skb(head);
+       kfree_skb(head);
        ipq_put(qp);
 }