OSDN Git Service

net: ti: am65-cpsw-nuss: remove guards against !BRIDGE_VLAN_INFO_BRENTRY
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 16 Feb 2022 16:47:51 +0000 (18:47 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Feb 2022 14:17:10 +0000 (14:17 +0000)
Since commit 3116ad0696dd ("net: bridge: vlan: don't notify to switchdev
master VLANs without BRENTRY flag"), the bridge no longer emits
switchdev notifiers for VLANs that don't have the
BRIDGE_VLAN_INFO_BRENTRY flag, so these checks are dead code.
Remove them.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/am65-cpsw-switchdev.c

index 599708a..d4c56da 100644 (file)
@@ -237,15 +237,11 @@ static int am65_cpsw_port_vlans_add(struct am65_cpsw_port *port,
 {
        bool untag = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
        struct net_device *orig_dev = vlan->obj.orig_dev;
-       bool cpu_port = netif_is_bridge_master(orig_dev);
        bool pvid = vlan->flags & BRIDGE_VLAN_INFO_PVID;
 
        netdev_dbg(port->ndev, "VID add: %s: vid:%u flags:%X\n",
                   port->ndev->name, vlan->vid, vlan->flags);
 
-       if (cpu_port && !(vlan->flags & BRIDGE_VLAN_INFO_BRENTRY))
-               return 0;
-
        return am65_cpsw_port_vlan_add(port, untag, pvid, vlan->vid, orig_dev);
 }