OSDN Git Service

wl3501_cs: Remove unnecessary NULL check
authorAlex Dewar <alex.dewar90@gmail.com>
Sat, 26 Sep 2020 17:45:58 +0000 (18:45 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 29 Sep 2020 08:25:30 +0000 (11:25 +0300)
In wl3501_detach(), link->priv is checked for a NULL value before being
passed to free_netdev(). However, it cannot be NULL at this point as it
has already been passed to other functions, so just remove the check.

Addresses-Coverity: CID 710499: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200926174558.9436-1-alex.dewar90@gmail.com
drivers/net/wireless/wl3501_cs.c

index 4e7a214..026e88b 100644 (file)
@@ -1433,9 +1433,7 @@ static void wl3501_detach(struct pcmcia_device *link)
        wl3501_release(link);
 
        unregister_netdev(dev);
-
-       if (link->priv)
-               free_netdev(link->priv);
+       free_netdev(dev);
 }
 
 static int wl3501_get_name(struct net_device *dev, struct iw_request_info *info,