OSDN Git Service

sunrpc: Fix potential leaks in sunrpc_cache_unhash()
authorTrond Myklebust <trondmy@gmail.com>
Mon, 6 Jan 2020 18:40:34 +0000 (13:40 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 22 Jan 2020 21:25:41 +0000 (16:25 -0500)
When we unhash the cache entry, we need to handle any pending upcalls
by calling cache_fresh_unlocked().

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/cache.c

index f740cb5..7ede1e5 100644 (file)
@@ -1888,7 +1888,9 @@ void sunrpc_cache_unhash(struct cache_detail *cd, struct cache_head *h)
        if (!hlist_unhashed(&h->cache_list)){
                hlist_del_init_rcu(&h->cache_list);
                cd->entries--;
+               set_bit(CACHE_CLEANED, &h->flags);
                spin_unlock(&cd->hash_lock);
+               cache_fresh_unlocked(h, cd);
                cache_put(h, cd);
        } else
                spin_unlock(&cd->hash_lock);