OSDN Git Service

dmaengine: mmp_tdma: Let the core do the device node validation
authorBaolin Wang <baolin.wang@linaro.org>
Mon, 20 May 2019 11:32:18 +0000 (19:32 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 27 May 2019 05:53:52 +0000 (11:23 +0530)
Let the DMA engine core do the device node validation instead of drivers.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mmp_tdma.c

index 0c56faa..e76858b 100644 (file)
@@ -586,18 +586,12 @@ static int mmp_tdma_chan_init(struct mmp_tdma_device *tdev,
 }
 
 struct mmp_tdma_filter_param {
-       struct device_node *of_node;
        unsigned int chan_id;
 };
 
 static bool mmp_tdma_filter_fn(struct dma_chan *chan, void *fn_param)
 {
        struct mmp_tdma_filter_param *param = fn_param;
-       struct mmp_tdma_chan *tdmac = to_mmp_tdma_chan(chan);
-       struct dma_device *pdma_device = tdmac->chan.device;
-
-       if (pdma_device->dev->of_node != param->of_node)
-               return false;
 
        if (chan->chan_id != param->chan_id)
                return false;
@@ -615,13 +609,13 @@ static struct dma_chan *mmp_tdma_xlate(struct of_phandle_args *dma_spec,
        if (dma_spec->args_count != 1)
                return NULL;
 
-       param.of_node = ofdma->of_node;
        param.chan_id = dma_spec->args[0];
 
        if (param.chan_id >= TDMA_CHANNEL_NUM)
                return NULL;
 
-       return dma_request_channel(mask, mmp_tdma_filter_fn, &param);
+       return __dma_request_channel(&mask, mmp_tdma_filter_fn, &param,
+                                    ofdma->of_node);
 }
 
 static const struct of_device_id mmp_tdma_dt_ids[] = {