OSDN Git Service

fbdev/da8xx-fb: Use fbdev I/O helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 3 Aug 2023 18:35:33 +0000 (20:35 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 4 Aug 2023 13:54:35 +0000 (15:54 +0200)
Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-9-tzimmermann@suse.de
drivers/video/fbdev/Kconfig
drivers/video/fbdev/da8xx-fb.c

index e5e5a49..e57588c 100644 (file)
@@ -1837,10 +1837,8 @@ config FB_DA8XX
        tristate "DA8xx/OMAP-L1xx/AM335x Framebuffer support"
        depends on FB && HAVE_CLK && HAS_IOMEM
        depends on ARCH_DAVINCI_DA8XX || SOC_AM33XX || COMPILE_TEST
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
        select FB_CFB_REV_PIXELS_IN_BYTE
+       select FB_IOMEM_HELPERS
        select FB_MODE_HELPERS
        select VIDEOMODE_HELPERS
        help
index 988dedc..4ca70a1 100644 (file)
@@ -1295,14 +1295,12 @@ static int da8xxfb_set_par(struct fb_info *info)
 
 static const struct fb_ops da8xx_fb_ops = {
        .owner = THIS_MODULE,
+       FB_DEFAULT_IOMEM_OPS,
        .fb_check_var = fb_check_var,
        .fb_set_par = da8xxfb_set_par,
        .fb_setcolreg = fb_setcolreg,
        .fb_pan_display = da8xx_pan_display,
        .fb_ioctl = fb_ioctl,
-       .fb_fillrect = cfb_fillrect,
-       .fb_copyarea = cfb_copyarea,
-       .fb_imageblit = cfb_imageblit,
        .fb_blank = cfb_blank,
 };