OSDN Git Service

ALSA: powermac: Deletion of an unnecessary check before the function call "pci_dev_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 17 Nov 2014 12:35:54 +0000 (13:35 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 17 Nov 2014 12:52:45 +0000 (13:52 +0100)
The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/pmac.c

index 8a431bc..5a13b22 100644 (file)
@@ -887,8 +887,7 @@ static int snd_pmac_free(struct snd_pmac *chip)
                }
        }
 
-       if (chip->pdev)
-               pci_dev_put(chip->pdev);
+       pci_dev_put(chip->pdev);
        of_node_put(chip->node);
        kfree(chip);
        return 0;