OSDN Git Service

usb: cdnsp: Removes some useless trace events
authorPawel Laszczak <pawell@cadence.com>
Thu, 4 Feb 2021 09:20:35 +0000 (10:20 +0100)
committerPeter Chen <peter.chen@kernel.org>
Sat, 6 Feb 2021 07:43:52 +0000 (15:43 +0800)
Patch removes some useless trace events that can
be replaced by ftrace.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Peter Chen <peter.chen@kernel.org>
drivers/usb/cdns3/cdnsp-ep0.c
drivers/usb/cdns3/cdnsp-gadget.c
drivers/usb/cdns3/cdnsp-ring.c
drivers/usb/cdns3/cdnsp-trace.h

index e2b1bcb..9b8325f 100644 (file)
@@ -24,13 +24,11 @@ static void cdnsp_ep0_stall(struct cdnsp_device *pdev)
        preq = next_request(&pep->pending_list);
 
        if (pdev->three_stage_setup) {
-               trace_cdnsp_ep0_data_stage("send stall");
                cdnsp_halt_endpoint(pdev, pep, true);
 
                if (preq)
                        cdnsp_gadget_giveback(pep, preq, -ECONNRESET);
        } else {
-               trace_cdnsp_ep0_status_stage("send stall");
                pep->ep_state |= EP0_HALTED_STATUS;
 
                if (preq)
@@ -45,8 +43,6 @@ static int cdnsp_ep0_delegate_req(struct cdnsp_device *pdev,
 {
        int ret;
 
-       trace_cdnsp_ep0_request("delagete");
-
        spin_unlock(&pdev->lock);
        ret = pdev->gadget_driver->setup(&pdev->gadget, ctrl);
        spin_lock(&pdev->lock);
@@ -130,7 +126,6 @@ static int cdnsp_ep0_set_address(struct cdnsp_device *pdev,
 
 int cdnsp_status_stage(struct cdnsp_device *pdev)
 {
-       trace_cdnsp_ep0_status_stage("preparing");
        pdev->ep0_stage = CDNSP_STATUS_STAGE;
        pdev->ep0_preq.request.length = 0;
 
index f28f150..f2ebbac 100644 (file)
@@ -237,8 +237,6 @@ static int cdnsp_start(struct cdnsp_device *pdev)
        temp |= (CMD_R_S | CMD_DEVEN);
        writel(temp, &pdev->op_regs->command);
 
-       trace_cdnsp_init("Turn on controller");
-
        pdev->cdnsp_state = 0;
 
        /*
index e15e13b..f9170d1 100644 (file)
@@ -266,7 +266,6 @@ static void cdnsp_force_l0_go(struct cdnsp_device *pdev)
 /* Ring the doorbell after placing a command on the ring. */
 void cdnsp_ring_cmd_db(struct cdnsp_device *pdev)
 {
-       trace_cdnsp_cmd_drbl("Ding Dong");
        writel(DB_VALUE_CMD, &pdev->dba->cmd_db);
 }
 
index a9de1da..5aa88ca 100644 (file)
@@ -158,11 +158,6 @@ DEFINE_EVENT(cdnsp_log_simple, cdnsp_slot_id,
        TP_ARGS(msg)
 );
 
-DEFINE_EVENT(cdnsp_log_simple, cdnsp_cmd_drbl,
-       TP_PROTO(char *msg),
-       TP_ARGS(msg)
-);
-
 DEFINE_EVENT(cdnsp_log_simple, cdnsp_no_room_on_ring,
        TP_PROTO(char *msg),
        TP_ARGS(msg)
@@ -173,11 +168,6 @@ DEFINE_EVENT(cdnsp_log_simple, cdnsp_ep0_status_stage,
        TP_ARGS(msg)
 );
 
-DEFINE_EVENT(cdnsp_log_simple, cdnsp_ep0_data_stage,
-       TP_PROTO(char *msg),
-       TP_ARGS(msg)
-);
-
 DEFINE_EVENT(cdnsp_log_simple, cdnsp_ep0_request,
        TP_PROTO(char *msg),
        TP_ARGS(msg)