OSDN Git Service

mt76: mt7915: fix decap offload corner case with 4-addr VLAN frames
authorFelix Fietkau <nbd@nbd.name>
Tue, 23 Nov 2021 10:37:47 +0000 (11:37 +0100)
committerFelix Fietkau <nbd@nbd.name>
Sun, 19 Dec 2021 14:24:00 +0000 (15:24 +0100)
With 4-address mode VLAN frames, an internal header translation step fails,
leaving behind an extra 2-byte length field that must be reomved by the driver.
Add a check for this condition to fix receiving such packets

Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7915/mac.c

index 2e156c8..c15beb4 100644 (file)
@@ -749,10 +749,29 @@ mt7915_mac_fill_rx(struct mt7915_dev *dev, struct sk_buff *skb)
                        return -EINVAL;
                hdr_trans = false;
        } else {
+               int pad_start = 0;
+
                skb_pull(skb, hdr_gap);
                if (!hdr_trans && status->amsdu) {
-                       memmove(skb->data + 2, skb->data,
-                               ieee80211_get_hdrlen_from_skb(skb));
+                       pad_start = ieee80211_get_hdrlen_from_skb(skb);
+               } else if (hdr_trans && (rxd2 & MT_RXD2_NORMAL_HDR_TRANS_ERROR)) {
+                       /*
+                        * When header translation failure is indicated,
+                        * the hardware will insert an extra 2-byte field
+                        * containing the data length after the protocol
+                        * type field.
+                        */
+                       pad_start = 12;
+                       if (get_unaligned_be16(skb->data + pad_start) == ETH_P_8021Q)
+                               pad_start += 4;
+
+                       if (get_unaligned_be16(skb->data + pad_start) !=
+                           skb->len - pad_start - 2)
+                               pad_start = 0;
+               }
+
+               if (pad_start) {
+                       memmove(skb->data + 2, skb->data, pad_start);
                        skb_pull(skb, 2);
                }
        }