OSDN Git Service

ftrace: Fix memory leak on failure path in ftrace_allocate_pages()
authorNamhyung Kim <namhyung@kernel.org>
Wed, 11 Jun 2014 08:06:53 +0000 (17:06 +0900)
committerSteven Rostedt <rostedt@goodmis.org>
Tue, 1 Jul 2014 11:13:40 +0000 (07:13 -0400)
As struct ftrace_page is managed in a single linked list, it should
free from the start page.

Link: http://lkml.kernel.org/p/1402474014-28655-1-git-send-email-namhyung@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/ftrace.c

index 39df319..e14ff4c 100644 (file)
@@ -2637,7 +2637,8 @@ ftrace_allocate_pages(unsigned long num_to_init)
        return start_pg;
 
  free_pages:
-       while (start_pg) {
+       pg = start_pg;
+       while (pg) {
                order = get_count_order(pg->size / ENTRIES_PER_PAGE);
                free_pages((unsigned long)pg->records, order);
                start_pg = pg->next;