OSDN Git Service

cxgb4: Fix endianness issue in t4_fwcache()
authorGanesh Goudar <ganeshgr@chelsio.com>
Fri, 14 Sep 2018 09:06:27 +0000 (14:36 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Nov 2019 14:53:58 +0000 (15:53 +0100)
[ Upstream commit 0dc235afc59a226d951352b0adf4a89b532a9d13 ]

Do not put host-endian 0 or 1 into big endian feild.

Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

index de23f23..832ad1b 100644 (file)
@@ -3482,7 +3482,7 @@ int t4_fwcache(struct adapter *adap, enum fw_params_param_dev_fwcache op)
        c.param[0].mnem =
                cpu_to_be32(FW_PARAMS_MNEM_V(FW_PARAMS_MNEM_DEV) |
                            FW_PARAMS_PARAM_X_V(FW_PARAMS_PARAM_DEV_FWCACHE));
-       c.param[0].val = (__force __be32)op;
+       c.param[0].val = cpu_to_be32(op);
 
        return t4_wr_mbox(adap, adap->mbox, &c, sizeof(c), NULL);
 }