OSDN Git Service

md.c:didn't unlock the mddev before return EINVAL in array_size_store
authorZhilong Liu <zlliu@suse.com>
Mon, 10 Apr 2017 06:15:55 +0000 (14:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Mar 2018 08:17:50 +0000 (09:17 +0100)
[ Upstream commit b670883bb9e55ba63a278d83e034faefc01ce2cf ]

md.c: it needs to release the mddev lock before
the array_size_store() returns.

Fixes: ab5a98b132fd ("md-cluster: change array_sectors and update size are not supported")

Signed-off-by: Zhilong Liu <zlliu@suse.com>
Reviewed-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/md.c

index 27d8bb2..a7bc703 100644 (file)
@@ -4826,8 +4826,10 @@ array_size_store(struct mddev *mddev, const char *buf, size_t len)
                return err;
 
        /* cluster raid doesn't support change array_sectors */
-       if (mddev_is_clustered(mddev))
+       if (mddev_is_clustered(mddev)) {
+               mddev_unlock(mddev);
                return -EINVAL;
+       }
 
        if (strncmp(buf, "default", 7) == 0) {
                if (mddev->pers)