OSDN Git Service

wireguard: socket: remove extra call to synchronize_net
authorJason A. Donenfeld <Jason@zx2c4.com>
Fri, 14 Feb 2020 22:57:23 +0000 (23:57 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Feb 2020 03:21:56 +0000 (19:21 -0800)
synchronize_net() is a wrapper around synchronize_rcu(), so there's no
point in having synchronize_net and synchronize_rcu back to back,
despite the documentation comment suggesting maybe it's somewhat useful,
"Wait for packets currently being received to be done." This commit
removes the extra call.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireguard/socket.c

index 262f3b5..b0d6541 100644 (file)
@@ -432,7 +432,6 @@ void wg_socket_reinit(struct wg_device *wg, struct sock *new4,
                wg->incoming_port = ntohs(inet_sk(new4)->inet_sport);
        mutex_unlock(&wg->socket_update_lock);
        synchronize_rcu();
-       synchronize_net();
        sock_free(old4);
        sock_free(old6);
 }