OSDN Git Service

scsi: scsi_dh_alua: fix missing kref_put() in alua_rtpg_work()
authortang.junhui <tang.junhui@zte.com.cn>
Fri, 28 Oct 2016 07:54:07 +0000 (15:54 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 1 Nov 2016 17:31:08 +0000 (13:31 -0400)
Reference count of pg leaks in alua_rtpg_work() since kref_put() is not
called to decrease the reference count of pg when the condition
pg->rtpg_sdev==NULL satisfied (actually it is easy to satisfy), it would
cause memory of pg leakage.

Signed-off-by: tang.junhui <tang.junhui@zte.com.cn>
Cc: <stable@vger.kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/device_handler/scsi_dh_alua.c

index 241829e..f375167 100644 (file)
@@ -793,6 +793,7 @@ static void alua_rtpg_work(struct work_struct *work)
                WARN_ON(pg->flags & ALUA_PG_RUN_RTPG);
                WARN_ON(pg->flags & ALUA_PG_RUN_STPG);
                spin_unlock_irqrestore(&pg->lock, flags);
+               kref_put(&pg->kref, release_port_group);
                return;
        }
        if (pg->flags & ALUA_SYNC_STPG)