OSDN Git Service

NFS: remove special-case revalidate in nfs_opendir()
authorNeilBrown <neilb@suse.com>
Fri, 25 Aug 2017 07:34:41 +0000 (17:34 +1000)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Mon, 16 Oct 2017 17:51:27 +0000 (13:51 -0400)
Commit f5a73672d181 ("NFS: allow close-to-open cache semantics to
apply to root of NFS filesystem") added a call to
__nfs_revalidate_inode() to nfs_opendir to as the lookup
process wouldn't reliable do this.

Subsequent commit a3fbbde70a0c ("VFS: we need to set LOOKUP_JUMPED
on mountpoint crossing") make this unnecessary.  So remove the
unnecessary code.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/dir.c

index c583093..15104f7 100644 (file)
@@ -118,13 +118,6 @@ nfs_opendir(struct inode *inode, struct file *filp)
                goto out;
        }
        filp->private_data = ctx;
-       if (filp->f_path.dentry == filp->f_path.mnt->mnt_root) {
-               /* This is a mountpoint, so d_revalidate will never
-                * have been called, so we need to refresh the
-                * inode (for close-open consistency) ourselves.
-                */
-               __nfs_revalidate_inode(NFS_SERVER(inode), inode);
-       }
 out:
        put_rpccred(cred);
        return res;