OSDN Git Service

media: cobalt: do not register subdev nodes
authorHans Verkuil <hverkuil@xs4all.nl>
Mon, 28 Aug 2017 08:45:58 +0000 (04:45 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sat, 23 Sep 2017 18:58:22 +0000 (14:58 -0400)
In the distant past the adv7604 driver used private controls. In order
to access them the v4l-subdevX nodes were needed. Later the is_private
tag was removed in the adv7604 driver and the need for v4l-subdevX
device nodes disappeared.

Remove the creation of those device nodes from this driver.

Note: the cobalt card is only used inside Cisco and we never actually
used the v4l-subdevX nodes for anything. So this API change can be done
safely without breaking anything.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/cobalt/cobalt-driver.c

index 8487eca..3f16cf3 100644 (file)
@@ -738,9 +738,6 @@ static int cobalt_probe(struct pci_dev *pci_dev,
                        goto err_i2c;
        }
 
-       retval = v4l2_device_register_subdev_nodes(&cobalt->v4l2_dev);
-       if (retval)
-               goto err_i2c;
        retval = cobalt_nodes_register(cobalt);
        if (retval) {
                cobalt_err("Error %d registering device nodes\n", retval);