OSDN Git Service

powerpc/eeh: powerpc/eeh: Fix undefined variable
authorMike Qiu <qiudayu@linux.vnet.ibm.com>
Mon, 12 Aug 2013 06:15:36 +0000 (02:15 -0400)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 14 Aug 2013 05:33:16 +0000 (15:33 +1000)
changes for V4:
- changes the type of frozen_pe_no from %d to %llu
  in pr_devel()

'pe_no' hasn't been defined, it should be an typo error,
it should be 'frozen_pe_no'.

Also '__func__' has missed in IODA_EEH_DBG(),

For safety reasons, use pr_devel() directly, instead
of use IODA_EEH_DBG()

Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/platforms/powernv/eeh-ioda.c

index 0cd1c4a..cf42e74 100644 (file)
 #include "powernv.h"
 #include "pci.h"
 
-/* Debugging option */
-#ifdef IODA_EEH_DBG_ON
-#define IODA_EEH_DBG(args...)  pr_info(args)
-#else
-#define IODA_EEH_DBG(args...)
-#endif
-
 static char *hub_diag = NULL;
 static int ioda_eeh_nb_init = 0;
 
@@ -823,17 +816,17 @@ static int ioda_eeh_next_error(struct eeh_pe **pe)
 
                /* If OPAL API returns error, we needn't proceed */
                if (rc != OPAL_SUCCESS) {
-                       IODA_EEH_DBG("%s: Invalid return value on "
-                                    "PHB#%x (0x%lx) from opal_pci_next_error",
-                                    __func__, hose->global_number, rc);
+                       pr_devel("%s: Invalid return value on "
+                                "PHB#%x (0x%lx) from opal_pci_next_error",
+                                __func__, hose->global_number, rc);
                        continue;
                }
 
                /* If the PHB doesn't have error, stop processing */
                if (err_type == OPAL_EEH_NO_ERROR ||
                    severity == OPAL_EEH_SEV_NO_ERROR) {
-                       IODA_EEH_DBG("%s: No error found on PHB#%x\n",
-                                    __func__, hose->global_number);
+                       pr_devel("%s: No error found on PHB#%x\n",
+                                __func__, hose->global_number);
                        continue;
                }
 
@@ -842,8 +835,9 @@ static int ioda_eeh_next_error(struct eeh_pe **pe)
                 * highest priority reported upon multiple errors on the
                 * specific PHB.
                 */
-               IODA_EEH_DBG("%s: Error (%d, %d, %d) on PHB#%x\n",
-                       err_type, severity, pe_no, hose->global_number);
+               pr_devel("%s: Error (%d, %d, %llu) on PHB#%x\n",
+                        __func__, err_type, severity,
+                        frozen_pe_no, hose->global_number);
                switch (err_type) {
                case OPAL_EEH_IOC_ERROR:
                        if (severity == OPAL_EEH_SEV_IOC_DEAD) {