OSDN Git Service

net/mlx5e: Remove warning "devices are not on same switch HW"
authorMaor Dickman <maord@mellanox.com>
Sun, 24 May 2020 06:45:44 +0000 (09:45 +0300)
committerSaeed Mahameed <saeedm@mellanox.com>
Fri, 29 May 2020 20:07:53 +0000 (13:07 -0700)
On tunnel decap rule insertion, the indirect mechanism will attempt to
offload the rule on all uplink representors which will trigger the
"devices are not on same switch HW, can't offload forwarding" message
for the uplink which isn't on the same switch HW as the VF representor.

The above flow is valid and shouldn't cause warning message,
fix by removing the warning and only report this flow using extack.

Fixes: 321348475d54 ("net/mlx5e: Fix allowed tc redirect merged eswitch offload cases")
Signed-off-by: Maor Dickman <maord@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

index cac36c2..6e7b2ce 100644 (file)
@@ -3849,10 +3849,6 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv,
                                if (!mlx5e_is_valid_eswitch_fwd_dev(priv, out_dev)) {
                                        NL_SET_ERR_MSG_MOD(extack,
                                                           "devices are not on same switch HW, can't offload forwarding");
-                                       netdev_warn(priv->netdev,
-                                                   "devices %s %s not on same switch HW, can't offload forwarding\n",
-                                                   priv->netdev->name,
-                                                   out_dev->name);
                                        return -EOPNOTSUPP;
                                }