OSDN Git Service

drm/amdgpu: remove the redundant null checks
authorzhong jiang <zhongjiang@huawei.com>
Tue, 3 Sep 2019 06:15:05 +0000 (14:15 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 16 Sep 2019 15:42:56 +0000 (10:42 -0500)
debugfs_remove and kfree has taken the null check in account.
hence it is unnecessary to check it. Just remove the condition.
No functional change.

This issue was detected by using the Coccinelle software.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c

index 5652cc7..cb94627 100644 (file)
@@ -1077,8 +1077,7 @@ failure:
 
        ttm_bo_unlock_delayed_workqueue(&adev->mman.bdev, resched);
 
-       if (fences)
-               kfree(fences);
+       kfree(fences);
 
        return 0;
 }
@@ -1103,8 +1102,7 @@ int amdgpu_debugfs_init(struct amdgpu_device *adev)
 
 void amdgpu_debugfs_preempt_cleanup(struct amdgpu_device *adev)
 {
-       if (adev->debugfs_preempt)
-               debugfs_remove(adev->debugfs_preempt);
+       debugfs_remove(adev->debugfs_preempt);
 }
 
 #else