OSDN Git Service

mtd: rawnand: hynix: Use ->exec_op() in hynix_nand_reg_write_op()
authorBoris Brezillon <boris.brezillon@bootlin.com>
Wed, 4 Jul 2018 14:08:58 +0000 (16:08 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 18 Jul 2018 08:10:15 +0000 (10:10 +0200)
Modern NAND controller drivers implement ->exec_op() instead of
->cmdfunc(), make sure we don't end up with a NULL pointer dereference
when hynix_nand_reg_write_op() is called.

Fixes: 8878b126df76 ("mtd: nand: add ->exec_op() implementation")
Cc: <stable@vger.kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/nand_hynix.c

index 8cbe77f..4ffbb26 100644 (file)
@@ -100,6 +100,16 @@ static int hynix_nand_reg_write_op(struct nand_chip *chip, u8 addr, u8 val)
        struct mtd_info *mtd = nand_to_mtd(chip);
        u16 column = ((u16)addr << 8) | addr;
 
+       if (chip->exec_op) {
+               struct nand_op_instr instrs[] = {
+                       NAND_OP_ADDR(1, &addr, 0),
+                       NAND_OP_8BIT_DATA_OUT(1, &val, 0),
+               };
+               struct nand_operation op = NAND_OPERATION(instrs);
+
+               return nand_exec_op(chip, &op);
+       }
+
        chip->cmdfunc(mtd, NAND_CMD_NONE, column, -1);
        chip->write_byte(mtd, val);