2000-11-06 Fernando Nasser <fnasser@cygnus.com>

        * interface.tcl (show_warning): Add missing argument to ide_messageBox
        and add comments explaining why we use it for windows.

diff --git a/gdb/gdbtk/library/ChangeLog b/gdb/gdbtk/library/ChangeLog
index d988ef1..4f85897 100644 (file)
--- a/gdb/gdbtk/library/ChangeLog
+++ b/gdb/gdbtk/library/ChangeLog
@@ -1,3 +1,8 @@
+2000-11-06  Fernando Nasser  <fnasser@cygnus.com>
+
+       * interface.tcl (show_warning): Add missing argument to ide_messageBox
+       and add comments explaining why we use it for windows.
+
 2000-11-01  Larry Smith  <lsmith@redhat.com>
 
         * console.itb (_build_win): Added code to remove horizontal

diff --git a/gdb/gdbtk/library/interface.tcl b/gdb/gdbtk/library/interface.tcl
index 1ab4b7f..1669bf1 100644 (file)
--- a/gdb/gdbtk/library/interface.tcl
+++ b/gdb/gdbtk/library/interface.tcl
@@ -332,9 +332,20 @@ proc show_warning {message} {
   # here.
   set title "GDB"
   set modal "task"
+
+# On Windows, we use ide_messageBox which runs the Win32 MessageBox function
+# in another thread.  This permits a program which handles IDE requests from
+# other programs to not return from the request until the MessageBox completes.
+# This is not possible without using another thread, since the MessageBox
+# function call will be running its own event loop, and will be higher on the
+# stack than the IDE request.
+#
+# On Unix tk_messageBox runs in the regular Tk event loop, so
+# another thread is not required.
+
  
   if {$tcl_platform(platform) == "windows"} {
-      ide_messageBox -icon warning \
+      ide_messageBox [list set r] -icon warning \
         -default ok -message $message -title $title \
         -type ok -modal $modal -parent .
   } else {